<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Function.prototype.toString is incorrect for ArrowFunction"
href="https://bugs.webkit.org/show_bug.cgi?id=148148">bug 148148</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259404 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Function.prototype.toString is incorrect for ArrowFunction"
href="https://bugs.webkit.org/show_bug.cgi?id=148148#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Function.prototype.toString is incorrect for ArrowFunction"
href="https://bugs.webkit.org/show_bug.cgi?id=148148">bug 148148</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259404&action=diff" name="attach_259404" title="Patch">attachment 259404</a> <a href="attachment.cgi?id=259404&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259404&action=review">https://bugs.webkit.org/attachment.cgi?id=259404&action=review</a>
r=me
Please reupload with fixed Nit and added test cases for arrow function body expressions that don't end in ";" and I will r+/cq+
<span class="quote">> Source/JavaScriptCore/parser/ASTBuilder.h:375
> + SourceCode source = m_sourceCode->subExpression(functionInfo.startOffset, functionInfo.body->isArrowFunctionBodyExpression() ? functionInfo.endOffset -1 : functionInfo.endOffset, functionInfo.startLine, functionInfo.bodyStartColumn);</span >
Nit: space between "-" and "1"
<span class="quote">> Source/JavaScriptCore/parser/ASTBuilder.h:376
> ArrowFuncExprNode* result = new (m_parserArena) ArrowFuncExprNode(location, *functionInfo.name, functionInfo.body, source);</span >
The - 1 worries me.
Does this work:
function foo(x) { print(x.toString() }
foo((y)=>y)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>