<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439">bug 148439</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259880 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439">bug 148439</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259880&action=diff" name="attach_259880" title="Patch">attachment 259880</a> <a href="attachment.cgi?id=259880&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259880&action=review">https://bugs.webkit.org/attachment.cgi?id=259880&action=review</a>
<span class="quote">> Source/WTF/wtf/Assertions.h:51
> +#include <os/trace.h></span >
is this what breaks iOS build?
/Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/usr/local/include/wtf/spi/darwin/XPCSPI.h:37:1: error: typedef redefinition with different types ('NSObject<OS_xpc_object> *' vs 'void *')
OS_OBJECT_DECL(xpc_object);
^
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:33
> +#if __has_include(<CommonCrypto/CommonRandomSPI.h>)</span >
This check will fail for open source WebKit builds (including nightlies), because CommonRandomSPI.h is an internal header.
In WebCore, we declare it in crypto/CommonCryptoUtilities.h - or you could add a CommonCryptoSPI header in WTF.
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:72
> + if (result != kCCSuccess)
> + CRASH_WITH_MESSAGE("crytographicallyRandomValuesFromOS could not get cryptographically random information from CCRandomCopyBytes and had error: %d", result);</span >
I'm not sure how this is more helpful than a simple RELEASE_ASSERT. We can see where that one happens, and CCRandomCopyBytes can't fail anyway.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>