<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439">bug 148439</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259880&action=diff" name="attach_259880" title="Patch">attachment 259880</a> <a href="attachment.cgi?id=259880&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259880&action=review">https://bugs.webkit.org/attachment.cgi?id=259880&action=review</a>
<span class="quote">> Source/WTF/wtf/Assertions.h:55
> +#if defined(__has_include)
> +#if __has_include(<os/trace.h>)
> +#define HAVE_OS_TRACE 1
> +#include <os/trace.h>
> +#else
> +#define HAVE_OS_TRACE 0
> +#endif
> +#endif</span >
Would it make sense to move the define for HAVE_OS_TRACE to wtf/Platform.h? Notice that wtf/Platform.h defines HAVE_OS_ACTIVITY, which we use to guard inclusion and data types defined in header os/activity.h.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>