<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac"
href="https://bugs.webkit.org/show_bug.cgi?id=147320">bug 147320</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259523 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac"
href="https://bugs.webkit.org/show_bug.cgi?id=147320#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac"
href="https://bugs.webkit.org/show_bug.cgi?id=147320">bug 147320</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259523&action=diff" name="attach_259523" title="Patch">attachment 259523</a> <a href="attachment.cgi?id=259523&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259523&action=review">https://bugs.webkit.org/attachment.cgi?id=259523&action=review</a>
<span class="quote">> Source/WebCore/page/WheelEventDeltaFilter.h:46
> + WEBCORE_EXPORT virtual FloatSize filteredDelta() const = 0;</span >
Why is this function virtual? Both classes just return m_currentFilteredDelta
<span class="quote">> Source/WebCore/page/WheelEventDeltaFilter.h:52
> +const size_t basicWheelEventDeltaFilterWindowSize = 3;</span >
Don't think this needs to be in the header.
<span class="quote">> Source/WebCore/page/WheelEventDeltaFilter.h:68
> + virtual bool isFilteringDeltas() const override
> + {
> + return m_isTrackingDeltas;</span >
Why the naming disparity?
<span class="quote">> Source/WebCore/page/WheelEventDeltaFilter.h:80
> + bool m_isTrackingDeltas;</span >
{ false }
<span class="quote">> Source/WebCore/page/mac/WheelEventDeltaFilterMac.h:58
> + bool m_isFilteringDeltas { false };</span >
Name differs from the basic filter. Why not move to the base class?
<span class="quote">> Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:38
> + , m_predominantAxisFilter([[_NSScrollingPredominantAxisFilter alloc] init])</span >
This is a leak. You need an adoptNS here.
<span class="quote">> Source/WebCore/platform/spi/mac/NSScrollingInputFilterSPI.h:39
> +- (BOOL)resetIfOutOfDate:(NSTimeInterval)timestamp;</span >
Unused. Only declare things you actually use.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>