<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035">bug 148035</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259427&action=diff" name="attach_259427" title="Patch">attachment 259427</a> <a href="attachment.cgi?id=259427&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259427&action=review">https://bugs.webkit.org/attachment.cgi?id=259427&action=review</a>
<span class="quote">>> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototypeInlines.h:37
>> +#define CALL_GENERIC_TYPEDARRAY_PROTOTYPE_FUNCTION(functionName) do { \
>
> You should just use an inline function here. It's easier to debug and not any slower.</span >
Unfortunately, I don't think that's possible as the function is a templated thing and C++ can't take templated functions as parameters. At least as far as I know.
<span class="quote">>> Source/JavaScriptCore/runtime/JSTypedArrayViewPrototypeInlines.h:65
>> +static EncodedJSValue JSC_HOST_CALL typedArrayViewPrivateFuncLength(ExecState* exec)
>
> Why are all of these functions in an Inlines.h file? It seems that we never inline them.
>
> I think all of this stuff belongs in a .cpp file somewhere.</span >
That was an oversight on my part. At one point I had some template functions in here but when I removed them I forgot to move everything to a .cpp file. It's fixed now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>