<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dino@apple.com" title="Dean Jackson <dino@apple.com>"> <span class="fn">Dean Jackson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Select validation does not correctly work when handling change event"
href="https://bugs.webkit.org/show_bug.cgi?id=145869">bug 145869</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259434 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Select validation does not correctly work when handling change event"
href="https://bugs.webkit.org/show_bug.cgi?id=145869#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Select validation does not correctly work when handling change event"
href="https://bugs.webkit.org/show_bug.cgi?id=145869">bug 145869</a>
from <span class="vcard"><a class="email" href="mailto:dino@apple.com" title="Dean Jackson <dino@apple.com>"> <span class="fn">Dean Jackson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259434&action=diff" name="attach_259434" title="Patch">attachment 259434</a> <a href="attachment.cgi?id=259434&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259434&action=review">https://bugs.webkit.org/attachment.cgi?id=259434&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:14
> + Test: fast/forms/onchange-select-check-validity.html
> +
> + When selecting an option in a <select> with validation that also has an onchange listener, calling
> + checkValidity() for the select within the onchange handler would produce incorrect results and (on
> + a debug build) crash at an assertion. This is because the change events were being dispatched before
> + form validity was updated. Making the validation step come before the change event dispatch fixes
> + this issue.</span >
Normally the Test line comes last.
<span class="quote">> LayoutTests/fast/forms/onchange-select-check-validity.html:17
> + select.onchange = showFormValidity;
> + select.addEventListener("change", showFormValidity);</span >
I think these two lines do the same thing. You only need one of them.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>