<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - GraphicsContext3D::activeTexture should not be called with zero-based index"
href="https://bugs.webkit.org/show_bug.cgi?id=148020#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - GraphicsContext3D::activeTexture should not be called with zero-based index"
href="https://bugs.webkit.org/show_bug.cgi?id=148020">bug 148020</a>
from <span class="vcard"><a class="email" href="mailto:sabouhallawa@apple.com" title="Said Abou-Hallawa <sabouhallawa@apple.com>"> <span class="fn">Said Abou-Hallawa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258989&action=diff" name="attach_258989" title="Patch">attachment 258989</a> <a href="attachment.cgi?id=258989&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258989&action=review">https://bugs.webkit.org/attachment.cgi?id=258989&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:11
> + No new tests because there is no behavior change.</span >
There should be a behavior change since there is a bug in passing the wrong parameter value to GraphicsContext3D::activeTexture(). Can not we have a layout test or even a test case which shows the rendering difference between before and after the fix?
<span class="quote">> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4064
> + m_context->activeTexture(m_activeTextureUnit + GraphicsContext3D::TEXTURE0);</span >
Yes this looks a correct fix. This can be verified from <a href="https://www.khronos.org/opengles/sdk/docs/man/xhtml/glActiveTexture.xml">https://www.khronos.org/opengles/sdk/docs/man/xhtml/glActiveTexture.xml</a> and from WebGLRenderingContextBase::activeTexture() in which we set m_activeTextureUnit = texture - GraphicsContext3D::TEXTURE0.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>