<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Search fields should scale when rendering while zoomed"
href="https://bugs.webkit.org/show_bug.cgi?id=147867">bug 147867</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #258999 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Search fields should scale when rendering while zoomed"
href="https://bugs.webkit.org/show_bug.cgi?id=147867#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Search fields should scale when rendering while zoomed"
href="https://bugs.webkit.org/show_bug.cgi?id=147867">bug 147867</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258999&action=diff" name="attach_258999" title="Patch">attachment 258999</a> <a href="attachment.cgi?id=258999&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258999&action=review">https://bugs.webkit.org/attachment.cgi?id=258999&action=review</a>
Thank you for iterating on the patch.
<span class="quote">> Source/WebCore/ChangeLog:14
> + (WebCore::RenderThemeMac::paintMenuList): Refactored to use paintCellAndSetFocusedElementNeedsRepaintIfNecessary</span >
Nit: Missing period at the end of this sentence.
<span class="quote">> Source/WebCore/rendering/RenderThemeMac.mm:1462
> + bool shouldUseImageBuffer = renderer.style().effectiveZoom() != 1.0f || page->pageScaleFactor() != 1.0f;</span >
It's not necessary to use the .0f suffix as per the WebKit Code Style guidelines.
<span class="quote">> Source/WebCore/rendering/RenderThemeMac.mm:1464
> + if (ThemeMac::drawCellOrFocusRingWithViewIntoContext(cell, paintInfo.context, rect, documentViewFor(renderer), shouldDrawCell, shouldDrawFocusRing, shouldUseImageBuffer, page->deviceScaleFactor()))</span >
I know this is not part of your patch. I noticed that ThemeMac::drawCellOrFocusRingWithViewIntoContext() takes its first argument as a RetainPtr. Can we have it take a raw pointer?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>