<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Add TypedArray.prototype functionality."
href="https://bugs.webkit.org/show_bug.cgi?id=148035">bug 148035</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259030&action=diff" name="attach_259030" title="Patch">attachment 259030</a> <a href="attachment.cgi?id=259030&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259030&action=review">https://bugs.webkit.org/attachment.cgi?id=259030&action=review</a>
<span class="quote">> Source/JavaScriptCore/builtins/TypedArray.prototype.js:30
> +function every(callback /*, thisArg */) {
> + "use strict";
> + var length = @typedArrayLength(this);</span >
I recently unified our style for the builtins to be:
function functionName(arguments)
{
"use strict";
rest of function goes here
}
It would be great if we could keep it consistent.
<span class="quote">> Source/JavaScriptCore/builtins/TypedArray.prototype.js:98
> + for (var i = 0; i < length; i++)
> + if (callback.@call(thisArg, this[i], i, this))
> + return true;</span >
This for loop should have braces.
<span class="quote">> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:343
> + // This is matching FireFox behavior. In particular, it rejects all attempts to</span >
This seems unrelated and I don't think it is correct. Firefox is spelled as one word.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>