<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Cover memory cache subresource validation policy with cache tests"
href="https://bugs.webkit.org/show_bug.cgi?id=147830">bug 147830</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #258891 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Cover memory cache subresource validation policy with cache tests"
href="https://bugs.webkit.org/show_bug.cgi?id=147830#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Cover memory cache subresource validation policy with cache tests"
href="https://bugs.webkit.org/show_bug.cgi?id=147830">bug 147830</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258891&action=diff" name="attach_258891" title="patch">attachment 258891</a> <a href="attachment.cgi?id=258891&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258891&action=review">https://bugs.webkit.org/attachment.cgi?id=258891&action=review</a>
Nice!
<span class="quote">> Source/WebCore/loader/FrameLoader.h:288
> + void setStrictRawResourceValidationPolicyDisabledForTesting(bool b) { m_isStrictRawResourceValidationPolicyDisabledForTesting = b; }</span >
I'd use a real word instead of "b" here.
<span class="quote">> Source/WebCore/loader/FrameLoader.h:289
> + bool isStrictRawResourceValidationPolicyDisabledForTesting() { return m_isStrictRawResourceValidationPolicyDisabledForTesting; }</span >
strictRawResourceValidationPolicyIsDisabledForTesting would result in better grammar in conditional constructs.
<span class="quote">> Source/WebCore/loader/cache/CachedResourceLoader.cpp:699
> + // FIXME: We should have same cache policy for all resource types.</span >
It is good to add a FIXME here. It would be even more helpful to explain why.
<span class="quote">> Source/WebCore/loader/cache/CachedResourceLoader.cpp:701
> + bool strictPolicyDisabled = frame()->loader().isStrictRawResourceValidationPolicyDisabledForTesting();</span >
When we use frame() elsewhere in this function, it's passed down to logMemoryCacheResourceRequest, which has a null check.
It seems that frame can't be null, yet I wanted to call your attention to the fact that the patch adds what looks like the first unchecked use of frame in this function.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>