<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Make run-benchmark cleanup more robust and minor code cleaning"
href="https://bugs.webkit.org/show_bug.cgi?id=147800#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Make run-benchmark cleanup more robust and minor code cleaning"
href="https://bugs.webkit.org/show_bug.cgi?id=147800">bug 147800</a>
from <span class="vcard"><a class="email" href="mailto:dewei_zhu@apple.com" title="dewei_zhu@apple.com">dewei_zhu@apple.com</a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258655&action=diff" name="attach_258655" title="Patch">attachment 258655</a> <a href="attachment.cgi?id=258655&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258655&action=review">https://bugs.webkit.org/attachment.cgi?id=258655&action=review</a>
<span class="quote">>> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:90
>> + self._web_root = benchmark_builder.prepare(self._plan_name, self._plan)
>
> This shouldn't be an instance variable since it's only used within _run_benchmark.
> It should be an argument to _run_benchmark instead.
>
> It's also strange that BenchmarkBuilder constructor takes no value and we have to call prepare separately.
> We should combine these two and use "with" statement instead of manually calling clean() below.</span >
Good idea!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>