<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956#c111">Comment # 111</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956">bug 144956</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258572&action=diff" name="attach_258572" title="Patch">attachment 258572</a> <a href="attachment.cgi?id=258572&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258572&action=review">https://bugs.webkit.org/attachment.cgi?id=258572&action=review</a>
<span class="quote">>>> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-4557
>>> -</Project>
>>
>> Is this intended?
>
> Is this intended?</span >
Reverted
<span class="quote">>>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:729
>>> + return UnlinkedFunctionExecutable::create(m_vm, m_scopeNode->source(), body, isBuiltinFunction() ? UnlinkedBuiltinFunction : UnlinkedNormalFunction, constructAbility, variablesUnderTDZ, nullptr);
>>
>> Not: if nullptr is already the default parameter here you can revert this line.
>
> Not: if nullptr is already the default parameter here you can revert this line.</span >
Done
<span class="quote">>>> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:852
>>> + case NewArrowFunction: {
>>
>> Nit:
>> This code is mostly the same as the NewFunction case.
>> I think it's better to have these cases be the same and then
>> have them differ where they need to based on op == NewArrowFunction.
>> I know this is a bit pedantic it's better for future proofing code.
>
> Nit:
> This code is mostly the same as the NewFunction case.
> I think it's better to have these cases be the same and then
> have them differ where they need to based on op == NewArrowFunction.
> I know this is a bit pedantic it's better for future proofing code.</span >
Refactored
<span class="quote">>>> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:1446
>>> + case Allocation::Kind::NewArrowFunction: {
>>
>> Ditto here.
>
> Ditto here.</span >
Done
<span class="quote">>>> Source/JavaScriptCore/jit/JITOperations.cpp:945
>>> +EncodedJSValue static operationNewArrowFunctionCommon(ExecState* exec, JSScope* scope, JSCell* functionExecutable, EncodedJSValue thisValue, bool isInvalidated)
>>
>> Nit: call this operationNewFunctionCommon
>
> Nit: call this operationNewFunctionCommon</span >
Renamed
<span class="quote">>>> Source/JavaScriptCore/jit/JITOperations.cpp:947
>>> + UNUSED_PARAM(thisValue);
>>
>> This seems wrong. You do use "thisValue"
>
> This seems wrong. You do use "thisValue"</span >
Fixed
<span class="quote">>>> Source/JavaScriptCore/parser/Nodes.h:1880
>>> + class ArrowFuncExprNode : public FuncExprNode {
>>
>> I would either have his inherit from ExpressionNode or create a new
>> parent class that both FuncExprNode and ArrowFuncExprNode inherit from.
>> This inheritance chain seems a bit weird.
>
> I would either have his inherit from ExpressionNode or create a new
> parent class that both FuncExprNode and ArrowFuncExprNode inherit from.
> This inheritance chain seems a bit weird.</span >
Done. Added new class BaseFuncExprNode</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>