<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Parse the entire WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147393">bug 147393</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #258288 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Parse the entire WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147393#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Parse the entire WebAssembly modules"
href="https://bugs.webkit.org/show_bug.cgi?id=147393">bug 147393</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258288&action=diff" name="attach_258288" title="Override JSCell::destroy()">attachment 258288</a> <a href="attachment.cgi?id=258288&action=edit" title="Override JSCell::destroy()">[details]</a></span>
Override JSCell::destroy()
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258288&action=review">https://bugs.webkit.org/attachment.cgi?id=258288&action=review</a>
r=me
<span class="quote">>> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:108
>> + m_module->i32Constants().append(constant);
>
> I think this (and all appends below) can be uncheckedAppend() since we're reserving their space up front.</span >
I agree.
<span class="quote">> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:138
> + m_module->signatures().append(signature);</span >
Same here, and a few places below..</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>