<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] ENABLE_OPENGL=OFF builds still include GL-specific files"
href="https://bugs.webkit.org/show_bug.cgi?id=146511">bug 146511</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257251 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] ENABLE_OPENGL=OFF builds still include GL-specific files"
href="https://bugs.webkit.org/show_bug.cgi?id=146511#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] ENABLE_OPENGL=OFF builds still include GL-specific files"
href="https://bugs.webkit.org/show_bug.cgi?id=146511">bug 146511</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257251&action=diff" name="attach_257251" title="Patch">attachment 257251</a> <a href="attachment.cgi?id=257251&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257251&action=review">https://bugs.webkit.org/attachment.cgi?id=257251&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp:25
> #include "config.h"
> +
> +#if USE(TEXTURE_MAPPER_GL)
> #include "BitmapTextureGL.h"</span >
We don't do this. The header should be guarded too, and then here include config.h and the main header unconditionally, and then we guard the rest of the file.
<span class="quote">> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:24
> #include "config.h"
> +
> +#if USE(TEXTURE_MAPPER_GL)</span >
Same here. Also it's a bit weird that the header has #if USE(TEXTURE_MAPPER) and the implementation USE(TEXTURE_MAPPER_GL). They should have the same condition. I guess what you want is to change the header in this case.
<span class="quote">> Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:26
> +#if USE(TEXTURE_MAPPER_GL)
> +
> #include "TextureMapperShaderProgram.h"</span >
Same here.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1370
> + Window native;</span >
setNativeSurfaceHandleForCompositing expects a uint64_t, so use that instead of Window. Also, this is not an if but an #if, so you don't need to declare this variable here, you can do it when assigned below on each #if branch. And use a better name, windowID, for example.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>