<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add a focus manager that WebKit clients can use to access the focused media element"
href="https://bugs.webkit.org/show_bug.cgi?id=147629#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add a focus manager that WebKit clients can use to access the focused media element"
href="https://bugs.webkit.org/show_bug.cgi?id=147629">bug 147629</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258191&action=diff" name="attach_258191" title="Patch">attachment 258191</a> <a href="attachment.cgi?id=258191&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258191&action=review">https://bugs.webkit.org/attachment.cgi?id=258191&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp:67
> + ASSERT(proxy);</span >
No real need for this assert if you're just going to go ahead and dereference the null pointer two lines away.
<span class="quote">> Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:38
> +typedef std::tuple<WebPageProxy*, uint64_t> FocusedMediaElement;</span >
might be clearer if this is a std::pair? then you don't have the fairly surprising std::get in the impl. Unless you're planning to add more components.
<span class="quote">> Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:40
> +class WebMediaSessionFocusManager: public API::ObjectImpl<API::Object::Type::MediaSessionFocusManager>, public WebContextSupplement {</span >
space before the colon
<span class="quote">> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:-7626
> - 15739BBD1B42042D00D258C1 /* WebUserMediaClient.h in Headers */,</span >
This patch is doing a surprising about of xcodeproj reordering.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>