<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor and improve TextIndicator to prepare for tests"
href="https://bugs.webkit.org/show_bug.cgi?id=147622#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor and improve TextIndicator to prepare for tests"
href="https://bugs.webkit.org/show_bug.cgi?id=147622">bug 147622</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258167&action=diff" name="attach_258167" title="preliminary patch for ews">attachment 258167</a> <a href="attachment.cgi?id=258167&action=edit" title="preliminary patch for ews">[details]</a></span>
preliminary patch for ews
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258167&action=review">https://bugs.webkit.org/attachment.cgi?id=258167&action=review</a>
<span class="quote">> Source/WebCore/page/TextIndicator.cpp:127
> + if ((!renderer->isInline() || renderer->isReplaced()) && range.intersectsNode(node, ASSERT_NO_EXCEPTION))</span >
Counting inline-but-replaced as "complex" is one of the big behavior changes.
<span class="quote">> Source/WebCore/page/TextIndicator.cpp:188
> + if (textRects.isEmpty()) {</span >
This block (falling back to the bounding rect if we are asked to or if we end up with no text rects, and clipping said bounding rect to the visible rect) is one of the big behavior changes.
Humorously, this also lets us use TextIndicator for images on Mac, and it looks pretty reasonable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>