<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: let UI clients query whether a media element is paused"
href="https://bugs.webkit.org/show_bug.cgi?id=147588#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: let UI clients query whether a media element is paused"
href="https://bugs.webkit.org/show_bug.cgi?id=147588">bug 147588</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147588#c4">comment #4</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=258134&action=diff" name="attach_258134" title="Patch">attachment 258134</a> <a href="attachment.cgi?id=258134&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=258134&action=review">https://bugs.webkit.org/attachment.cgi?id=258134&action=review</a>
>
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4072
> > + send(Messages::WebPageProxy::DidGetIsMediaElementPaused(callbackID, paused));
>
> You could/should use the GenericCallback (specifically UnsignedCallback)
> mechanism here. Look around for examples. And probably your API (which
> oddly, I don't see here) should let people provide a block/function to call
> back (look at WKPageForceRepaint for an example, though that one doesn't
> return a value).</span >
I do use GenericCallback. I didn't realize I could just use UnsignedCallback instead of writing custom callbacks. Sending out a new revision.
<span class="quote">>
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:753
> > + void getIsMediaElementPaused(uint64_t, uint64_t);
>
> No "get" here; we usually reserve that for functions with out arguments.</span >
Renamed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>