<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to non-Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147414">bug 147414</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257774 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to non-Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147414#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to non-Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147414">bug 147414</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257774&action=diff" name="attach_257774" title="Patch">attachment 257774</a> <a href="attachment.cgi?id=257774&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257774&action=review">https://bugs.webkit.org/attachment.cgi?id=257774&action=review</a>
<span class="quote">> LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31
> + video.play();</span >
Nit: If you want to add the event listener with "video.on<event type>", I think it will make the test results easier to understand if you log the event name as you would if you used waitForEvent, eg:
consoleWrite("EVENT(" + event.type + ")");
<span class="quote">> LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62
> + <p>'Transient' sessions should not respond to Play/Pause media control events.</p></span >
You are testing both transient and ambient sessions.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>