<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: VoiceOver unable to access content in malformed trees"
href="https://bugs.webkit.org/show_bug.cgi?id=147295">bug 147295</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257795 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: VoiceOver unable to access content in malformed trees"
href="https://bugs.webkit.org/show_bug.cgi?id=147295#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: VoiceOver unable to access content in malformed trees"
href="https://bugs.webkit.org/show_bug.cgi?id=147295">bug 147295</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257795&action=diff" name="attach_257795" title="patch">attachment 257795</a> <a href="attachment.cgi?id=257795&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257795&action=review">https://bugs.webkit.org/attachment.cgi?id=257795&action=review</a>
thanks. almost there
<span class="quote">> Source/WebCore/ChangeLog:9
> + VoiceOver is skipping the content of malformed trees. Fixed it by ignoring</span >
VoiceOver is skipping the content of malformed trees.
This fixes the problem by having the tree check if it has valid children (tree items) and makes tree items check if they are inside trees.
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.h:776
> + // Function to determine if the attribute role should be ignored</span >
this comment probably not necessary. your method name does the same thing that this comment says
<span class="quote">> Source/WebCore/accessibility/AccessibilityTree.cpp:72
> + // A valid tree can only have treeitem or group of treeitems as child</span >
"... as a child."
<span class="quote">> Source/WebCore/accessibility/AccessibilityTree.cpp:75
> + Deque<Node*> queue;</span >
we should make this queue after we check if there's node (next line)
<span class="quote">> Source/WebCore/accessibility/AccessibilityTree.cpp:85
> + Node* child = queue.takeFirst();</span >
auto child
<span class="quote">> Source/WebCore/accessibility/AccessibilityTree.cpp:89
> + if (nodeHasRole(child, "treeitem"))</span >
does nodeHasRole already check the is<Element> for us? we might be able to get rid of that check
<span class="quote">> Source/WebCore/accessibility/AccessibilityTreeItem.cpp:56
> + m_isTreeItemValid = false;</span >
it looks like we don't need to initialize this to anything so the line below will take care of it
<span class="quote">> Source/WebCore/accessibility/AccessibilityTreeItem.cpp:58
> + // Walk the parent chain looking for a parent that is a tree, treeitem is considered</span >
// Walk the parent chain looking for a parent that is a tree. A tree item is only considered valid if it is in a tree.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>