<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147413#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147413">bug 147413</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147413#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=257767&action=diff" name="attach_257767" title="Patch">attachment 257767</a> <a href="attachment.cgi?id=257767&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=257767&action=review">https://bugs.webkit.org/attachment.cgi?id=257767&action=review</a>
>
> > LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt:18
> > +EVENT(canplaythrough)
> > +EXPECTED (internals.mediaSessionCurrentState(session) == 'idle') OK
> > +Idle Media Sessions should not respond to Play/Pause events.
> > +EXPECTED (video.paused == 'true') OK
> > +Sending Play/Pause media event.
> > +RUN(internals.sendMediaControlEvent("play-pause"))
> > +EXPECTED (video.paused == 'true') OK
> > +Playing media.
> > +Media began playing.
> > +EXPECTED (video.paused == 'false') OK
> > +EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
> > +Sending Play/Pause media event.
> > +RUN(internals.sendMediaControlEvent("play-pause"))
> > +EXPECTED (video.paused == 'true') OK
> > +END OF TEST
>
> Nit: I think it will be much easier to understand these results if you put a
> blank line between logical tests.</span >
Fixed.
<span class="quote">>
> > LayoutTests/media/session/play-pause-media-events-in-content-sessions.html:44
> > + function beganPlaying(event)
> > + {
> > + video.onplaying = null;
> > +
> > + consoleWrite("Media began playing.");
> > + testExpected('video.paused', false);
>
> Ditto my comments in previous patches about manually adding logging if you
> use "video.on<event type>".</span >
I switched to `waitForEvent`.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>