<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147413">bug 147413</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257767 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147413#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: test Play/Pause media control events delivered to Content media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=147413">bug 147413</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257767&action=diff" name="attach_257767" title="Patch">attachment 257767</a> <a href="attachment.cgi?id=257767&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257767&action=review">https://bugs.webkit.org/attachment.cgi?id=257767&action=review</a>
<span class="quote">> LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt:18
> +EVENT(canplaythrough)
> +EXPECTED (internals.mediaSessionCurrentState(session) == 'idle') OK
> +Idle Media Sessions should not respond to Play/Pause events.
> +EXPECTED (video.paused == 'true') OK
> +Sending Play/Pause media event.
> +RUN(internals.sendMediaControlEvent("play-pause"))
> +EXPECTED (video.paused == 'true') OK
> +Playing media.
> +Media began playing.
> +EXPECTED (video.paused == 'false') OK
> +EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
> +Sending Play/Pause media event.
> +RUN(internals.sendMediaControlEvent("play-pause"))
> +EXPECTED (video.paused == 'true') OK
> +END OF TEST</span >
Nit: I think it will be much easier to understand these results if you put a blank line between logical tests.
<span class="quote">> LayoutTests/media/session/play-pause-media-events-in-content-sessions.html:44
> + function beganPlaying(event)
> + {
> + video.onplaying = null;
> +
> + consoleWrite("Media began playing.");
> + testExpected('video.paused', false);</span >
Ditto my comments in previous patches about manually adding logging if you use "video.on<event type>".</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>