<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:p.jacquemart@samsung.com" title="Pascal Jacquemart <p.jacquemart@samsung.com>"> <span class="fn">Pascal Jacquemart</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Adding default implementation for JavaScript watchdog."
href="https://bugs.webkit.org/show_bug.cgi?id=147107">bug 147107</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257832 Flags</td>
<td>review?
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Adding default implementation for JavaScript watchdog."
href="https://bugs.webkit.org/show_bug.cgi?id=147107#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Adding default implementation for JavaScript watchdog."
href="https://bugs.webkit.org/show_bug.cgi?id=147107">bug 147107</a>
from <span class="vcard"><a class="email" href="mailto:p.jacquemart@samsung.com" title="Pascal Jacquemart <p.jacquemart@samsung.com>"> <span class="fn">Pascal Jacquemart</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257832&action=diff" name="attach_257832" title="Patch">attachment 257832</a> <a href="attachment.cgi?id=257832&action=edit" title="Patch">[details]</a></span>
Patch
Not asking for review, just saving the work in progress...
Thanks Mark for you comment on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - watchdog m_didFire state erroneously retained"
href="show_bug.cgi?id=131082">Bug 131082</a>, it seems I missed the obvious...
Calling JSContextGroupSetExecutionTimeLimit() from a WebExtension / injected bundle is working fine... while using the appropriate callback.
In this concern "load_started" is fine because it is calling JSContextGroupSetExecutionTimeLimit() for each page load hence reseting m_didFire state
I can try to use WTF::WorkQueue, it sounds great!
Actually it seems we could apply the same treatment to remove / refactor heap/HeapTimer.cpp/.h</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>