<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add API to WebKitWebsiteDataManager to handle session and local storage"
href="https://bugs.webkit.org/show_bug.cgi?id=147319#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add API to WebKitWebsiteDataManager to handle session and local storage"
href="https://bugs.webkit.org/show_bug.cgi?id=147319">bug 147319</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147319#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=257557&action=diff" name="attach_257557" title="Patch">attachment 257557</a> <a href="attachment.cgi?id=257557&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=257557&action=review">https://bugs.webkit.org/attachment.cgi?id=257557&action=review</a>
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:824
> > + origins = g_list_prepend(origins, webkitSecurityOriginCreate(origin.get()));
>
> Same question as on your other patch: I guess the same origin is guaranteed
> to not exist in multiple WebsiteDataRecords returned by this query?
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:836
> > + * @error: return location for error or %NULL to ignore
>
> Again, same question as on your other patch: the GError is not supposed to
> have any annotations?</span >
I think this is automatically handled by g-i, the method is marked as throws="1" in the gir file and the parameter is simply removed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>