<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly module parser"
href="https://bugs.webkit.org/show_bug.cgi?id=147293">bug 147293</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #257558 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly module parser"
href="https://bugs.webkit.org/show_bug.cgi?id=147293#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebAssembly module parser"
href="https://bugs.webkit.org/show_bug.cgi?id=147293">bug 147293</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257558&action=diff" name="attach_257558" title="Patch">attachment 257558</a> <a href="attachment.cgi?id=257558&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257558&action=review">https://bugs.webkit.org/attachment.cgi?id=257558&action=review</a>
r=me with some mixups
<span class="quote">> Source/JavaScriptCore/parser/SourceProvider.h:90
> +#if ENABLE(WEBASSEMBLY)
> + virtual bool isStringSource() const override
> + {
> + return true;
> + }
> +#endif</span >
SourceProvider has a subclass named "StringSourceProvider". This function is too easily confused with that class.
For now, I think you should remove this function. Instead of performing an isStringSource() check, I think you should just go with the [WebAssembly Source] source string you've provided. In the future, we'll have to see what the spec says about toString on a WebAssembly function.
<span class="quote">> Source/JavaScriptCore/wasm/WASMFormat.h:33
> +static const uint32_t wasmMagicNumber = 0x6d736177;</span >
This file should be named WASMMagicNumber.h.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>