<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Crash in CurlDownload::didReceiveHeader when downloading file."
href="https://bugs.webkit.org/show_bug.cgi?id=146832#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Crash in CurlDownload::didReceiveHeader when downloading file."
href="https://bugs.webkit.org/show_bug.cgi?id=146832">bug 146832</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146832#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=257466&action=diff" name="attach_257466" title="Patch">attachment 257466</a> <a href="attachment.cgi?id=257466&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=257466&action=review">https://bugs.webkit.org/attachment.cgi?id=257466&action=review</a>
>
> > Source/WebCore/platform/network/curl/CurlDownload.cpp:309
> > + ref(); // The download manager will call deref when the download has finished.
>
> Might be better to say "CurlDownloadManager::downloadThread" will call deref
> when the download has finished.
>
> > Source/WebCore/platform/network/curl/CurlDownload.cpp:407
> > + ref();
>
> You can capture a RefPtr to do this without an explicit ref/deref;
> RefPtr<CurlDownload> protectedDownload(this) or capturedDownload and then
> capture that. Doing that has a slight clarity advantage of running the deref
> if the lambda is ever deleted without being called, not an issue in these
> cases. Sometimes people capture both the RefPtr and "this".</span >
Thanks for reviewing :) I will update the patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>