<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043">bug 147043</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=257148&action=diff" name="attach_257148" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">attachment 257148</a> <a href="attachment.cgi?id=257148&action=edit" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">[details]</a></span>
Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=257148&action=review">https://bugs.webkit.org/attachment.cgi?id=257148&action=review</a>
<span class="quote">>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:110
>> + queueInfo.branch = queueInfo.combinedQueues ? null : queueInfo.branch || this.defaultBranches;
>
> Why can't a combined queue be on a branch? We don't have any now, but I don't see any intrinsic reason for this limitation.
>
> The operator precedence here seems non-obvious enough that I'd have appreciated parentheses.</span >
It seems that a combined queue is just a collection of sub-queues and that information pertaining to the repository/branch, etc. of the individual queues would be better kept at the sub-queue level. Especially in the case where the individual sub-queues have different repositories, what would it mean for the containing combined queue to have a repository associated with it?
As Dan Bates mentioned to me, the parentheses are not necessary according to this: <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence">https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence</a>
However, I agree that a set of parentheses might be nice to emphasize which part is evaluated first for someone who does not have this reference handy and does not have the operator precedence memorized.
<span class="quote">>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:28
>> + var all_branch = {};
>
> "all_branch" is neither named according to WebKit style, nor grammatically correct.</span >
I agree that this is not grammatically correct. This was not my initial choice for variable name, but I wanted to remain consistent with the choice of "branch" on the "BuildbotQueue" object (a data structure that contains repository to branch mappings). Would "all_branches" be a better choice?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>