<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043">bug 147043</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256978 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #256978 Flags</td>
<td>review?
</td>
<td>
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #257148 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo."
href="https://bugs.webkit.org/show_bug.cgi?id=147043">bug 147043</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=257148&action=diff" name="attach_257148" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">attachment 257148</a> <a href="attachment.cgi?id=257148&action=edit" title="Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.">[details]</a></span>
Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
Currently the "_normalizeQueueInfo" method is adding some hardcoded defaults for the queueInfo.branch data structure. I have been working with Dan Bates on a more generic solution in which the defaults may be specified instead by a Buildbot base class getter method (which returns an empty dictionary) that can be overridden by inheriting classes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>