<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Cleanup PasteboardHelper"
   href="https://bugs.webkit.org/show_bug.cgi?id=147035#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Cleanup PasteboardHelper"
   href="https://bugs.webkit.org/show_bug.cgi?id=147035">bug 147035</a>
              from <span class="vcard"><a class="email" href="mailto:zan&#64;falconsigh.net" title="Zan Dobersek &lt;zan&#64;falconsigh.net&gt;"> <span class="fn">Zan Dobersek</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=256960&amp;action=diff" name="attach_256960" title="Patch">attachment 256960</a> <a href="attachment.cgi?id=256960&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256960&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=256960&amp;action=review</a>

<span class="quote">&gt; Source/WebCore/ChangeLog:11
&gt; +        PasteboardHelper::singleton() and make it non-copiable, fast</span >

Nit: non-copyable.

<span class="quote">&gt; Source/WebCore/platform/gtk/PasteboardHelper.cpp:70
&gt; +    gMarkupPrefix = String::fromUTF8(&quot;&lt;meta http-equiv=\&quot;content-type\&quot; content=\&quot;text/html; charset=utf-8\&quot;&gt;&quot;);</span >

Not terribly important since it's only called once, but this string seems ASCII-only, so you could initialize gMarkipPrefix from an ASCIILiteral.

Also, can this be initialized where it's declared?

<span class="quote">&gt; Source/WebCore/platform/gtk/PasteboardHelper.h:38
&gt; +    WTF_MAKE_NONCOPYABLE(PasteboardHelper); WTF_MAKE_FAST_ALLOCATED;</span >

No need for WTF_MAKE_FAST_ALLOCATED. There's only one object alive during the program's lifetime, and that one is constructed in memory that's reserved by the static NeverDestroyed&lt;PasteboardHelper&gt; object.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>