<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add support for platform-specific interruption providers"
href="https://bugs.webkit.org/show_bug.cgi?id=147008#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add support for platform-specific interruption providers"
href="https://bugs.webkit.org/show_bug.cgi?id=147008">bug 147008</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147008#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256916&action=diff" name="attach_256916" title="Patch">attachment 256916</a> <a href="attachment.cgi?id=256916&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256916&action=review">https://bugs.webkit.org/attachment.cgi?id=256916&action=review</a>
>
> > Source/WebCore/ChangeLog:9
> > + * platform/audio/MediaSessionInterruptionProvider.cpp: Added base class to be used by MediaSessionManager to
>
> Nit: This isn't audio-specific, so why don't you put it into a new
> "platform/mediasession" directory?</span >
Will do.
<span class="quote">>
> > Source/WebCore/platform/audio/MediaSessionInterruptionProvider.cpp:37
> > +MediaSessionInterruptionProvider::MediaSessionInterruptionProvider(MediaSessionInterruptionProviderClient& client)
> > + : m_client(&client)
> > +{
> > + beginListeningForInterruptions();
> > +}
>
> Will there ever be more than one interruption provider? If so, what is the
> lifetime of an object - who creates it?</span >
The interruption provider will only be used by the MediaSessionManager singleton (there will only be one client).
<span class="quote">>
> If there will only ever be one, you need a static accessor method and you
> need a way to add/remove clients.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>