<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953">bug 146953</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256816 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Negative scroll snap repeat values cause web process to hang indefinitely"
href="https://bugs.webkit.org/show_bug.cgi?id=146953">bug 146953</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256816&action=diff" name="attach_256816" title="Patch">attachment 256816</a> <a href="attachment.cgi?id=256816&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256816&action=review">https://bugs.webkit.org/attachment.cgi?id=256816&action=review</a>
<span class="quote">> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:90
> + LayoutUnit repeatOffset = points ? valueForLength(points->repeatOffset, viewSize) : LayoutUnit(1.0f);</span >
LayoutUnit(1.0f) should be LayoutUnit::fromPixel(1)
<span class="quote">> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:92
> + if (repeatOffset.toFloat() < 1.0f)
> + repeatOffset = LayoutUnit(1.0f);</span >
repeatOffset = std::min<LayoutUnit>(repeatOffset, 1);
<span class="quote">> LayoutTests/css3/scroll-snap/scroll-snap-negative-repeat.html:39
> + <style>
> + #gallery {
> + height: 400px;
> + width: 400px;
> + overflow-x: hidden;
> + overflow-y: auto;
> + -webkit-overflow-scrolling: touch;
> + -webkit-scroll-snap-type: mandatory;
> + -webkit-scroll-snap-points-y: repeat(-400px);
> + margin: 0;
> + padding: 0;
> + }
> +
> + .colorBox {
> + width: 400px;
> + height: 400px;
> + }
> +
> + #item0 { background-color: red; }
> + #item1 { background-color: green; }
> + #item2 { background-color: blue; }
> + #item3 { background-color: aqua; }
> + #item4 { background-color: yellow; }
> + #item5 { background-color: fuchsia; }
> + </style>
> + <script src="../../resources/js-test-pre.js"></script>
> + </head>
> + <body>
> + <div id="gallery">
> + <div id="item0" class="colorBox"></div>
> + <div id="item1" class="colorBox"></div>
> + <div id="item2" class="colorBox"></div>
> + <div id="item3" class="colorBox"></div>
> + <div id="item4" class="colorBox"></div>
> + <div id="item5" class="colorBox"></div>
> + </div></span >
Not sure that any of this is needed. Can't you just have body { -webkit-scroll-snap-type: mandatory; -webkit-scroll-snap-points-y: repeat(-400px); }
<span class="quote">> LayoutTests/css3/scroll-snap/scroll-snap-subpixel-repeat.html:10
> + -webkit-overflow-scrolling: touch;</span >
Remove this.
<span class="quote">> LayoutTests/css3/scroll-snap/scroll-snap-subpixel-repeat.html:34
> + testRunner.waitUntilDone();</span >
Not sure why the test needs to be async.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>