<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956#c51">Comment # 51</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this"
href="https://bugs.webkit.org/show_bug.cgi?id=144956">bug 144956</a>
from <span class="vcard"><a class="email" href="mailto:saambarati1@gmail.com" title="Saam Barati <saambarati1@gmail.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144956#c48">comment #48</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=256376&action=diff" name="attach_256376" title="Patch">attachment 256376</a> <a href="attachment.cgi?id=256376&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256376&action=review">https://bugs.webkit.org/attachment.cgi?id=256376&action=review</a>
>
> >> Source/JavaScriptCore/runtime/JSArrowFunction.cpp:101
> >> + // visitor.append(&thisObject->m_arrowFunction);
> >
> > This should be fixed.
>
> I can't reproduce this bug now :(. Possible it was fixed somewhere else.
>
> >> Source/JavaScriptCore/runtime/JSArrowFunction.h:69
> >> + const static unsigned StructureFlags = OverridesHasInstance | Base::StructureFlags;
> >
> > Looks like you're reporting the wrong things here.
> > It should have OverridesVisitChildren and it looks like it should
> > not have OverridesHasInstance.
> >
> > Let's see if that fixes GC issues.
>
> I've removed OverridesHasInstance but I didn't find OverridesVisitChildren
> method. Anyway it doesn't raise exception with now. Possible it was bug
> somewhere else.</span >
Yes. I don't think that exists anymore. I saw that flag on an old repository
on github while on my phone.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>