<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add selection-changed signal to the WebKit2 API"
href="https://bugs.webkit.org/show_bug.cgi?id=137116#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add selection-changed signal to the WebKit2 API"
href="https://bugs.webkit.org/show_bug.cgi?id=137116">bug 137116</a>
from <span class="vcard"><a class="email" href="mailto:tpopela@redhat.com" title="Tomas Popela <tpopela@redhat.com>"> <span class="fn">Tomas Popela</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=137116#c18">comment #18</a>)
<span class="quote">> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:115
> > +/**
> > + * webkit_web_editor_get_page:
> > + * @editor: a #WebKitWebEditor
> > + *
> > + * Gets the #WebKitWebPage that is associated with #WebKitWebEditor.
> > + *
> > + * Returns: (transfer none): the #WebKitWebPage that can be used to access
> > + * the #WebKitDOMDocument currently loaded into it.
>
> If this is mainly useful for accessing the DOM, maybe it makes more sense to
> have webkit_web_editor_get_dom_document?
> </span >
As you wrote in #c12:
<span class="quote">> the page associated to the editor, that can be used for anything else apart from accessing the DOM</span >
I would not do a special API just for accessing the DOM as for me it looks like some unnecessary and unwanted duplication. You are also closing the doors for accessing information that are in the WebKitWebPage (we really don't know what we will add there in the future) and I don't think we want to have getters for every interesting information in WebKitWebEditor's POV.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>