<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Crash in CurlDownload::didReceiveHeader when downloading file."
href="https://bugs.webkit.org/show_bug.cgi?id=146832">bug 146832</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256575 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Crash in CurlDownload::didReceiveHeader when downloading file."
href="https://bugs.webkit.org/show_bug.cgi?id=146832#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Crash in CurlDownload::didReceiveHeader when downloading file."
href="https://bugs.webkit.org/show_bug.cgi?id=146832">bug 146832</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256575&action=diff" name="attach_256575" title="Patch">attachment 256575</a> <a href="attachment.cgi?id=256575&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256575&action=review">https://bugs.webkit.org/attachment.cgi?id=256575&action=review</a>
<span class="quote">> Source/WebCore/platform/network/curl/CurlDownload.cpp:402
> + callOnMainThread([this, strUrl] {</span >
What guarantees the CurlDownload won’t be deleted between now and when the function is called on the main thread?
It’s not thread-safe to capture a string on one thread and use it on another. We need to use StringCapture instead to pass strings across threads.
<span class="quote">> Source/WebCore/platform/network/curl/CurlDownload.cpp:412
> + callOnMainThread([this, header] {</span >
What guarantees the CurlDownload won’t be deleted between now and when the function is called on the main thread?
It’s not thread-safe to capture a string on one thread and use it on another. We need to use StringCapture instead to pass strings across threads.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>