<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add actions to image previews"
href="https://bugs.webkit.org/show_bug.cgi?id=146702#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add actions to image previews"
href="https://bugs.webkit.org/show_bug.cgi?id=146702">bug 146702</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146702#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256337&action=diff" name="attach_256337" title="Patch">attachment 256337</a> <a href="attachment.cgi?id=256337&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256337&action=review">https://bugs.webkit.org/attachment.cgi?id=256337&action=review</a>
>
> > Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38
> > + _WKActivatedElementInfo *_activatedElementInfo;
>
> I think we should retain the _activeElementInfo.
> </span >
Will do.
<span class="quote">> > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298
> > + NSURL *targetURL = [NSURL URLWithString:positionInformation.url];
>
> Nit: Could we use _web_URLWithWTFString: here?
> </span >
Yes!
<span class="quote">> The patch looks good to me, I will let a WebKit reviewer to comment.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>