<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660">bug 146660</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>thorton@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660">bug 146660</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146660#c8">comment #8</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=146660#c7">comment #7</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=256308&action=diff" name="attach_256308" title="Patch">attachment 256308</a> <a href="attachment.cgi?id=256308&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=256308&action=review">https://bugs.webkit.org/attachment.cgi?id=256308&action=review</a>
> >
> > > Source/WebKit2/UIProcess/API/APIUIClient.h:61
> > > +#if ENABLE(MEDIA_SESSION)
> >
> > no need to guard this forward-declaration (but it's fine either way)
>
> I think I'll leave it in.</span >
That's fine! I only noted this because Darin has previously called this practice "overkill" (see <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Combine the TelephoneNumber and Selection overlay controllers, updating UI behavior"
href="show_bug.cgi?id=134461#c6">https://bugs.webkit.org/show_bug.cgi?id=134461#c6</a>).
<span class="quote">> > Why is this mapping #if'd out if WKMediaSessionMetadata has all the
> > functions but the contents of said functions are if'd out? Which way are you
> > disabling this?
>
> The contents of the functions have to be #if'd out since it doesn't seem
> like we can use #if ENABLE in those header files. I can remove the #if
> guards around the mapping.</span >
That's what I was hoping you'd do :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>