<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow the UIDelegate to customize an image preview"
href="https://bugs.webkit.org/show_bug.cgi?id=146557">bug 146557</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #256030 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow the UIDelegate to customize an image preview"
href="https://bugs.webkit.org/show_bug.cgi?id=146557#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow the UIDelegate to customize an image preview"
href="https://bugs.webkit.org/show_bug.cgi?id=146557">bug 146557</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256030&action=diff" name="attach_256030" title="Patch">attachment 256030</a> <a href="attachment.cgi?id=256030&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256030&action=review">https://bugs.webkit.org/attachment.cgi?id=256030&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:60
> +- (void)_webView:(WKWebView *)webView willPreviewImageWithURL:(NSURL *)imageURL;
> +- (void)_webView:(WKWebView *)webView commitPreviewedImageWithURL:(NSURL *)imageURL;</span >
Please add WK_AVAILABLE macros.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3216
> + id<WKUIDelegatePrivate> uiDelegate = static_cast<id <WKUIDelegatePrivate>>([_webView UIDelegate]);</span >
space after id
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3237
> + if (absoluteImageURL.isEmpty() || !WebCore::protocolIsInHTTPFamily(absoluteImageURL))</span >
At some point we should consider data: URL images.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3241
> + NSURL *targetURL = [NSURL _web_URLWithWTFString:_positionInformation.imageURL];</span >
No real need for the temporary, just like below.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3252
> + id<WKUIDelegatePrivate> uiDelegate = static_cast<id <WKUIDelegatePrivate>>([_webView UIDelegate]);</span >
space after id
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2162
> + info.imageURL = [(NSURL *)element->document().completeURL(downcast<HTMLImageElement>(*element).src()) absoluteString];</span >
What happens if it's a srcset image?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>