<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory leak for a protected element having pending events in ImageLoader"
href="https://bugs.webkit.org/show_bug.cgi?id=146538#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory leak for a protected element having pending events in ImageLoader"
href="https://bugs.webkit.org/show_bug.cgi?id=146538">bug 146538</a>
from <span class="vcard"><a class="email" href="mailto:beidson@apple.com" title="Brady Eidson <beidson@apple.com>"> <span class="fn">Brady Eidson</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146538#c3">comment #3</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=146538#c2">comment #2</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=255984&action=diff" name="attach_255984" title="Use RefPtr not calling ref/deref() directly">attachment 255984</a> <a href="attachment.cgi?id=255984&action=edit" title="Use RefPtr not calling ref/deref() directly">[details]</a></span>
> > Use RefPtr not calling ref/deref() directly
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=255984&action=review">https://bugs.webkit.org/attachment.cgi?id=255984&action=review</a>
> >
> > > Source/WebCore/loader/ImageLoader.cpp:363
> > > + m_protectedElement= &element();
> >
> > Type: Missing a space before the =.
> >
> > (Really bummed that check-webkit-style didn't get this)
> >
> > > Source/WebCore/loader/ImageLoader.cpp:372
> > > + m_protectedElement.clear();
> >
> > This should be:
> > m_protectedElement = nullptr;
>
>
> m_protectedElement is RefPtr.
> clear() will clear the internal pointer to nullptr.</span >
I know.
Assigning a nullptr to a RefPtr is functionally the same as calling clear() on it.
But when somebody not familiar with the code is reading it, and they come across a call to ".clear()", they don't necessarily know you're null'ing out a RefPtr. They might think you're calling "clear()" on some object that has a whole bunch of behavior inside of its ::clear() method.
But by assigning nullptr, it's obvious to anybody reading the code "This is a pointer - it might be a raw pointer or one of our various types of smart pointers, but I know it's a pointer and this code is null'ing it out"
This request is about readability by people not familiar with the code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>