<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473">bug 146473</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=255860&action=diff" name="attach_255860" title="Patch">attachment 255860</a> <a href="attachment.cgi?id=255860&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255860&action=review">https://bugs.webkit.org/attachment.cgi?id=255860&action=review</a>
<span class="quote">>> Source/WTF/wtf/OSRandomSource.cpp:53
>> +}
>
> Is there a good reason for these, isntead of just using CRASH or RELEASE_ASSERT_NOT_REACHED directly?</span >
I requested this so that we get back definitive crash traces that differentiate the one kind of failure from the other. Currently, our crash traces do not tell us which failure happened.
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:70
> + ssize_t currentRead = read(fd, buffer+amountRead, length-amountRead);</span >
Our style requires spacing around + and -.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>