<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473">bug 146473</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255860 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473">bug 146473</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255860&action=diff" name="attach_255860" title="Patch">attachment 255860</a> <a href="attachment.cgi?id=255860&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255860&action=review">https://bugs.webkit.org/attachment.cgi?id=255860&action=review</a>
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:53
> +NEVER_INLINE NO_RETURN_DUE_TO_CRASH static void crashUnableToOpenURandom()
> +{
> + CRASH();
> +}
> +
> +NEVER_INLINE NO_RETURN_DUE_TO_CRASH static void crashUnableToReadFromURandom()
> +{
> + CRASH();
> +}</span >
Is there a good reason for these, isntead of just using CRASH or RELEASE_ASSERT_NOT_REACHED directly?
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:72
> + if (currentRead < 0 && !(errno == EAGAIN || errno == EINTR))
> + crashUnableToReadFromURandom();</span >
This seems broken - if the currentRead is -1, then we don't want to add it to amountRead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>