<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473">bug 146473</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255864 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS."
href="https://bugs.webkit.org/show_bug.cgi?id=146473">bug 146473</a>
from <span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255864&action=diff" name="attach_255864" title="Patch">attachment 255864</a> <a href="attachment.cgi?id=255864&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255864&action=review">https://bugs.webkit.org/attachment.cgi?id=255864&action=review</a>
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:63
> + int fd;
> + // We need to check for both EAGAIN and EINTR since on some systems /dev/urandom
> + // is blocking and on others it is non-blocking.
> + do {
> + fd = open("/dev/urandom", O_RDONLY, 0);
> + } while (fd < 0 && (errno == EAGAIN || errno == EINTR));</span >
Remove this loop. I don't think there is a need to check for the EAGAIN and EINTR cases for open(). EAGAIN is documented to only happen for slave ptys and EINTR due to a signal.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>