<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - The bounds on InteractionInformationAtPosition should be more precise"
href="https://bugs.webkit.org/show_bug.cgi?id=146468">bug 146468</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255843 Flags</td>
<td>review+
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - The bounds on InteractionInformationAtPosition should be more precise"
href="https://bugs.webkit.org/show_bug.cgi?id=146468#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - The bounds on InteractionInformationAtPosition should be more precise"
href="https://bugs.webkit.org/show_bug.cgi?id=146468">bug 146468</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255843&action=diff" name="attach_255843" title="Patch">attachment 255843</a> <a href="attachment.cgi?id=255843&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255843&action=review">https://bugs.webkit.org/attachment.cgi?id=255843&action=review</a>
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2162
> + if (element->renderer())
> info.touchCalloutEnabled = element->renderer()->style().touchCalloutEnabled();</span >
Seems like you can just bail early from this function if element->renderer() is null.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2171
> + RefPtr<Range> linkRange = rangeOfContents(*linkElement);
> + Vector<FloatQuad> quads;
> + linkRange->textQuads(quads);
> + FloatRect linkBoundingBox;
> + for (const auto& quad : quads)
> + linkBoundingBox.unite(quad.enclosingBoundingBox());
> + info.bounds = IntRect(linkBoundingBox);</span >
This is just Range::boundingRect(), but that forces layout.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2172
> + } else if (element->renderer()) {</span >
if (RenderElement* renderer = element->renderer())...
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2177
> + info.bounds = element->renderer()->absoluteBoundingBoxRect(true);</span >
true is the default.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>