<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow other projects to display on the dashboard"
href="https://bugs.webkit.org/show_bug.cgi?id=146210">bug 146210</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255728 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow other projects to display on the dashboard"
href="https://bugs.webkit.org/show_bug.cgi?id=146210#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow other projects to display on the dashboard"
href="https://bugs.webkit.org/show_bug.cgi?id=146210">bug 146210</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255728&action=diff" name="attach_255728" title="Patch to allow for projects other than open source and internal on the dashboard.">attachment 255728</a> <a href="attachment.cgi?id=255728&action=edit" title="Patch to allow for projects other than open source and internal on the dashboard.">[details]</a></span>
Patch to allow for projects other than open source and internal on the dashboard.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255728&action=review">https://bugs.webkit.org/attachment.cgi?id=255728&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:116
> + if (isGitGotRevisonProperty(property, value))
> + return value;
> + else
> + return parseInt(value);</span >
We should have this function return a string and make it the caller's responsibility to parse the string for a number if needed. Then we can remove the function isGitGotRevisonProperty().
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:212
> + for (project in this.queue.branch) {</span >
This code is assuming that this.queue.branch represents a dictionary of (project, branch name)-pairs. Currently, this.queue.branch represents a dictionary of (repository, branch name)-pairs. Is this acceptable?
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:215
> + var revisionProperty = data.properties.findFirst(function(property) {
> + return isMultiCodebaseGotRevisionProperty(property) || property[0] === "got_revision";
> + });</span >
Notice that we compute this on each iteraiton. I suggest we move this out of the loop.
Also, the first disjunct is unnecessary by definition of isMultiCodebaseGotRevisionProperty().
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:222
> + this.otherRevision = parseRevisionProperty(revisionProperty, project, "Tools");</span >
Is it correct to fallback to using key Tools?
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:211
> + if (iteration.otherRevision)
> + content.textContent = iteration.otherRevision.substring(0, 8);</span >
This code assumes that iteration.otherRevision is always a Git revision. Is this correct?
How did you choose 8?
Did you mean to use String.substring() which takes a from and to argument for the indices?
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:267
> + return this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, true);</span >
How does this work if previousDisplayedIteration is non-null?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>