<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Test existence of controls on MediaSession"
href="https://bugs.webkit.org/show_bug.cgi?id=146356#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Test existence of controls on MediaSession"
href="https://bugs.webkit.org/show_bug.cgi?id=146356">bug 146356</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146356#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=255682&action=diff" name="attach_255682" title="Patch">attachment 255682</a> <a href="attachment.cgi?id=255682&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=255682&action=review">https://bugs.webkit.org/attachment.cgi?id=255682&action=review</a>
>
> > LayoutTests/ChangeLog:9
> > + * media/session/controls-existence-expected.txt: Added.
> > + * media/session/controls-existence.html: Added.
>
> You need to mark the new test as Skipped in
> LayoutTests/platform/mac/TestExpectations.</span >
Done. Wasn't sure if they were opt-in or opt-out.
<span class="quote">>
> > LayoutTests/media/session/controls-existence-expected.txt:6
> > +EXPECTED (session.controls != 'null') OK
> > +EXPECTED (session.controls == 'null') OK
> > +EXPECTED (session.controls == 'null') OK
> > +EXPECTED (session.controls == 'null') OK
>
> Nit: It can be helpful to have more context about what is being tested in
> the results, so it would be helpful to log the session type. For example:
>
> run("session = new MediaSession('content')");
> testExpected("session.controls", null, '!=');</span >
I'll do that.
<span class="quote">>
> or maybe
>
> testExpected("new MediaSession('content').controls", null, '!=');
>
> etc.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>