<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Improve binding generator naming for promise methods"
href="https://bugs.webkit.org/show_bug.cgi?id=146280">146280</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Improve binding generator naming for promise methods
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>528+ (Nightly build)
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebCore Misc.
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>youennf@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>Following on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Bindings generator should generate code to catch exception and reject promises for Promise-based APIs"
href="show_bug.cgi?id=146060">bug 146060</a>, we could do some improvements.
<span class="quote">>> Source/WebCore/bindings/js/JSDOMPromise.h:62
>> +template<class JSClassName></span >
>
<span class="quote">>The type here is the JavaScript class, not the JavaScript class name. I suggest the name WrapperClass here instead of JSClassName. Also, we almost always use typename rather >than class in templates, although I’m not entirely sure why.</span >
>
<span class="quote">>> Source/WebCore/bindings/js/JSDOMPromise.h:63
>> +inline JSC::JSValue callPromiseFunction(JSC::ExecState& state, JSClassName& jsObject, JSC::EncodedJSValue promiseFunction(JSC::ExecState*, JSClassName*, >JSC::JSPromiseDeferred*))</span >
>
<span class="quote">>A typical name used in bindings for what we are calling jsObject here is “wrapper”</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>