<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282">bug 146282</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255491 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282">bug 146282</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255491&action=diff" name="attach_255491" title="Patch">attachment 255491</a> <a href="attachment.cgi?id=255491&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255491&action=review">https://bugs.webkit.org/attachment.cgi?id=255491&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.cpp:104
> + m_document.page()->chrome().client().mediaSessionMetadataDidChange(m_metadata);</span >
What guarantees that page() is not null here? We should check it for null unless there is an ironclad guarantee it can’t be.
<span class="quote">> Source/WebCore/page/ChromeClient.h:50
> +#if ENABLE(MEDIA_SESSION)
> +#include "MediaSessionMetadata.h"
> +#endif</span >
We should not include this header. We should be able to just forward-declare MediaSessionMetadata to compile this header.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>