<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MediaSession: propagate MediaSessionMetadata to WebPageProxy"
href="https://bugs.webkit.org/show_bug.cgi?id=146282">bug 146282</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146282#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=255491&action=diff" name="attach_255491" title="Patch">attachment 255491</a> <a href="attachment.cgi?id=255491&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=255491&action=review">https://bugs.webkit.org/attachment.cgi?id=255491&action=review</a>
>
> > Source/WebCore/page/ChromeClient.h:49
> > +#include "MediaSessionMetadata.h"
>
> Please forward-declare instead of including this header (it seems like you
> can, right?). ChromeClient.h is included in a billion places and this will
> just make the build slower.</span >
Yup, fixed.
<span class="quote">>
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:5775
> > +{
>
> I assume you're going to put something here in a near-future patch?</span >
Yes. I have the changes locally.
<span class="quote">>
> > Source/WebKit2/UIProcess/WebPageProxy.h:123
> > +#if ENABLE(MEDIA_SESSION)
> > +#include <WebCore/MediaSessionMetadata.h>
>
> Ditto here.</span >
Changed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>