<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support releasing media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=146132#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support releasing media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=146132">bug 146132</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146132#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=255155&action=diff" name="attach_255155" title="Patch">attachment 255155</a> <a href="attachment.cgi?id=255155&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=255155&action=review">https://bugs.webkit.org/attachment.cgi?id=255155&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:84
> > + while (!m_activeParticipatingElements.isEmpty()) {
> > + HTMLMediaElement* element = m_activeParticipatingElements.takeAny();
> > + element->pause();
> > + }
>
> Could write this without the local variable:
>
> while (!m_activeParticipatingElements.isEmpty())
> m_activeParticipatingElements.takeAny()->pause();
>
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:98
> > + if (m_activeParticipatingElements.size() >= 1)
>
> I think !isEmpty() would be better. Sometimes it’s better not to take
> specification language too literally! One or more doesn’t have to turn into
> >= 1.</span >
Thanks for the feedback. Fixed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>