<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Strict Equality on objects should only check that one of the two sides is an object."
href="https://bugs.webkit.org/show_bug.cgi?id=145992">bug 145992</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255137 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #255266 Flags</td>
<td>
</td>
<td>review?, commit-queue?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Strict Equality on objects should only check that one of the two sides is an object."
href="https://bugs.webkit.org/show_bug.cgi?id=145992#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Strict Equality on objects should only check that one of the two sides is an object."
href="https://bugs.webkit.org/show_bug.cgi?id=145992">bug 145992</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=255266&action=diff" name="attach_255266" title="Patch">attachment 255266</a> <a href="attachment.cgi?id=255266&action=edit" title="Patch">[details]</a></span>
Patch
Changed the way the optimization works to what it probably should have been from the beginning. Now as long as one of the two arguments is an object we can just type check that side and ignore the type of the other (other than checking the tag is a cell tag in the 32-bit case). We still could be smarter about how we pick the side if both are objects but until we hoist type checks out of loops it probably doesn't matter.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>