<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Support releasing media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=146132">bug 146132</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #255155 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Support releasing media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=146132#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Support releasing media sessions"
href="https://bugs.webkit.org/show_bug.cgi?id=146132">bug 146132</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=255155&action=diff" name="attach_255155" title="Patch">attachment 255155</a> <a href="attachment.cgi?id=255155&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=255155&action=review">https://bugs.webkit.org/attachment.cgi?id=255155&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.cpp:84
> + while (!m_activeParticipatingElements.isEmpty()) {
> + HTMLMediaElement* element = m_activeParticipatingElements.takeAny();
> + element->pause();
> + }</span >
Could write this without the local variable:
while (!m_activeParticipatingElements.isEmpty())
m_activeParticipatingElements.takeAny()->pause();
<span class="quote">> Source/WebCore/Modules/mediasession/MediaSession.cpp:98
> + if (m_activeParticipatingElements.size() >= 1)</span >
I think !isEmpty() would be better. Sometimes it’s better not to take specification language too literally! One or more doesn’t have to turn into >= 1.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>