<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955#c65">Comment # 65</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955">bug 144955</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=254763&action=diff" name="attach_254763" title="Patch">attachment 254763</a> <a href="attachment.cgi?id=254763&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254763&action=review">https://bugs.webkit.org/attachment.cgi?id=254763&action=review</a>
<span class="quote">>> Source/JavaScriptCore/parser/Parser.h:833
>> +#endif
>
> Need to drop it.</span >
Done
<span class="quote">>> Source/JavaScriptCore/parser/SourceCode.h:129
>> + }
>
> Personally I think maintaining 2 same functions is error prone.
> In fact, RegExpPrototype.cpp is already using isLineTerminator. So I think using Lexer<UChar>::isLineTerminator not so problematic.
> Ideally, extracting these character related function into the different header from Lexer and this is nice.</span >
Lexer.h already is linked to SourceCode.h so we would be had circular dependancy. Anyway I've modified logic little bit and get rid of the LineTerminator check.
<span class="quote">>> Source/JavaScriptCore/parser/SourceProviderCacheItem.h:74
>> token.m_location.endOffset = closeBraceOffset + 1;
>
> Hmm, if m_type is not CLOSEBRACE, I think it's not correct because the token's endOffset is not closeBraceOffset + 1.
> And I think now `closeBraceOffset` name looks misleading because m_type may not be close brace.</span >
I've added additional parameter to store end of the function</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>